Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taikoon): fix taikoon contract test dependency issues #16862

Merged
merged 31 commits into from
Apr 29, 2024
Merged

fix(taikoon): fix taikoon contract test dependency issues #16862

merged 31 commits into from
Apr 29, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 26, 2024

No description provided.

bearni95 and others added 27 commits April 25, 2024 10:50
@bearni95
brought over contracts, tests and scripts; getting everything to run now
1992970
@bearni95
refreshed gitignore
b9b56ba
@bearni95
removed lib from tree
570e770
@bearni95
tracking pnpm-lock.yaml main
175e4a4
@bearni95
missing deps added to enable compiling
2d89594
@bearni95
format & mint
d3335f1
@bearni95
cleared lint warnings
cb4baca
@bearni95
updated pnpm; passing tests and build
d44c463
@bearni95
removed .gitmodules
6817f27
@bearni95
fixed typo leafs > leaves
71eaf4c
@bearni95
added build step to gha
2442adc
@bearni95
fixed merkle whitelist generation script under new location
7a522a2
@bearni95
localhost deployment re-enabled
5f55717
@bearni95
added holesky deployment
30ec660
@bearni95
restored ipfs deploy script
311d129
@bearni95
updated pnpm-lock.yaml
c7e5731
@bearni95
ran linter
3e2099f
@bearni95
simplified tests for taikoonToken.t.sol
8b42156
@bearni95
updated forge-std version
ae80196
@bearni95
added compile step to gha
9e6f6e9
@bearni95
fixed gha typo
bacd1d1
@bearni95
upgraded foundry toolchain version on gha
3bd7dad
@bearni95
upgraded foundry toolchain version on gha
ae94276
@bearni95
incorporated upgradeable constructor
dee3ea0
@bearni95
updated test command on gha
3217861
@bearni95
fixed test script
7e0753e
@dantaik
fix test issues
a3377f9
@dantaik dantaik marked this pull request as ready for review April 26, 2024 04:06
@dantaik dantaik changed the title fix(taikoon): test dependency issues fix(taikoon): fix taikoon contract test dependency issues Apr 26, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 26, 2024 •
edited
Loading

fix(taikoon): fix taikoon contract test dependency issues

Generated at commit: cbf00a4679666e33fcce7cfdf88456661e524bba

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
5
41
50
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

bearni95
bearni95 previously approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@bearni95 bearni95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the @openzeppelin/foundry-upgrades package was behind the test issues

Base automatically changed from taikoon-contracts-migration to main April 26, 2024 07:51
@dantaik dantaik dismissed bearni95’s stale review April 26, 2024 07:51

The base branch was changed.

@dantaik dantaik requested a review from bearni95 April 26, 2024 07:59
@dantaik dantaik enabled auto-merge April 26, 2024 08:00
@dantaik dantaik added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit bf31bb6 Apr 29, 2024
5 checks passed
@dantaik dantaik deleted the fix_nft_tests branch April 29, 2024 02:37
This was referenced May 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@bearni95 bearni95 bearni95 approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@2manslkh 2manslkh Awaiting requested review from 2manslkh

@bennettyong bennettyong Awaiting requested review from bennettyong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @bearni95 @davidtaikocha